Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advertise agent capabilities to support password-exposure hardening following the discovered CVE involving reusable HTTPS agent passwords in cloud VM metadata.
The builder queries the installed agent with
bosh-agent -featuresduring the agent stage and includes its reported capabilities instemcell.MF. The companion CLI enables password hashing only whenhttp-password-hmac-sha256is advertised. This ties capability detection to the actual packaged binary without a release-version threshold or API-version bump.Older agents reject the new flag; failed probes overwrite stale results with an empty list and retain legacy behavior. Missing or empty results omit the manifest field. Malformed successful probe output fails packaging. The temporary feature JSON is excluded from the stemcell archive.
Companion drafts:
The currently pinned agent is unchanged. The capability will activate when the normal agent release bump includes the supporting agent. This draft targets
ubuntu-jammy, the earliest supported branch, for subsequent merge-forward intoubuntu-nobleandubuntu-resolute.Validation before the capability rename: 16 packaging and probe examples passed, covering manifest and archive propagation, legacy compatibility, stale-feature clearing, and malformed metadata. Ruby Standard checks and shell syntax checks passed. The capability fixtures now use the HMAC marker; those examples have not been rerun for this revision. A full Linux stemcell image build was not run.
Password verifiers harden newly written metadata. Rotate previously exposed credentials to invalidate historical copies. Existing VMs are not rewritten by a no-change create-env run, and TLS private keys and other metadata secrets remain exposed. The companion CLI also has an explicit agent.mbus requirement requiring rollout review.