Skip to content

issue-1357: Add attribute allowpublic to uaa Client resource#1366

Open
damzog wants to merge 2 commits into
cloudfoundry:5.x.xfrom
boschglobal:5.x.x-issue-1357
Open

issue-1357: Add attribute allowpublic to uaa Client resource#1366
damzog wants to merge 2 commits into
cloudfoundry:5.x.xfrom
boschglobal:5.x.x-issue-1357

Conversation

@damzog

@damzog damzog commented Jul 17, 2026

Copy link
Copy Markdown

No description provided.

@Lokowandtg

Copy link
Copy Markdown
Contributor

As far as I can see, the code looks good and the existing tests run.
But there are no integration-tests. Can you add some or extend an existing one so it passes/validates the "allowpublic" value? If you need a local test environment, you can use kind-deployment. If that is a problem, please tell us where (in which existing test) the new flag will be passed to CF landscape and can be checked.
Thanks, Georg

@damzog

damzog commented Jul 22, 2026

Copy link
Copy Markdown
Author

@Lokowandtg I have added explicit setting and validating the flag in an existing integration test.

I actually tried to run the integration test against a kind-deployment (setting it up actually caused me some trouble) but I could not figure out the required values for TEST_ADMIN_CLIENTID , TEST_ADMIN_CLIENTSECRET ( I guess a client needed to be created first which would require to know uaa admin user name ) maybe if you can share some light into this?

Anyway the code is so simple it might even run without having tested it ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants