Prevent ThreadedWorker from leaking enqueue lifecycle callbacks - #5358
Open
philippthun wants to merge 1 commit into
Open
Prevent ThreadedWorker from leaking enqueue lifecycle callbacks#5358philippthun wants to merge 1 commit into
philippthun wants to merge 1 commit into
Conversation
Delayed::Plugin callbacks register against Delayed::Worker.lifecycle (the base class), and Delayed::Job.enqueue runs that same base lifecycle. Delayed::Worker#initialize calls self.class.setup_lifecycle, which rebuilds the lifecycle on the class it is called on. Since ThreadedWorker is a subclass, setup_lifecycle reset a different lifecycle than the base one the plugins append to. The base lifecycle was therefore never reset, and every ThreadedWorker.new added another before(:enqueue) callback to it. The before(:enqueue) callback creates a PollableJobModel row, so the accumulation caused a single enqueue to create many pollable rows. Production is unaffected since a worker is created once per process. Delegate setup_lifecycle and lifecycle on ThreadedWorker to the base class so each instantiation rebuilds the same lifecycle cleanly.
philippthun
marked this pull request as ready for review
August 11, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delayed::Plugincallbacks register againstDelayed::Worker.lifecycle(the base class), andDelayed::Job.enqueueruns that same base lifecycle.Delayed::Worker#initializecallsself.class.setup_lifecycle, which rebuilds thelifecycleon the class it is called on. SinceThreadedWorkeris a subclass,setup_lifecyclereset a differentlifecyclethan the base one the plugins append to. The baselifecyclewas therefore never reset, and everyThreadedWorker.newadded anotherbefore(:enqueue)callback to it.The
before(:enqueue)callback creates aPollableJobModelrow, so the accumulation caused a singleenqueueto create many pollable rows. Production is unaffected since a worker is created once per process.Delegate
setup_lifecycleandlifecycleonThreadedWorkerto the base class so each instantiation rebuilds the same lifecycle cleanly.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests