Adding command line option to watch a single namespace #742
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
augustoribeiro
force-pushed
the
watchworkspace
branch
from
9a6349a to
646c6b0
Compare
…if set Signed-off-by: augusto.ribeiro <augusto.ribeiro@cloudkitchens.com> Signed-off-by: augustoribeiro <augusto.mcc@gmail.com>
augustoribeiro
force-pushed
the
watchworkspace
branch
from
646c6b0 to
c3dbf48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently barman-cloud-plugin wants to watch resources cluster-wide. I would like it to allow for more restrictive rbac, like allowing it to only watch the target namespace where Clusters are actually provisioned.
This PR adds the
--watch-namespacecommand line option which restricts the reconciler to a single namespace.Tested this change in a development cluster. I am happy to write some integration test if somebody points me on how I should do that.
This is my first time contributing, if this submission is missing something feel free to comment