Skip to content

Conversation

@mbiagetti
Copy link
Contributor

@mbiagetti mbiagetti commented Jan 29, 2026

The testing framework does not support conditional templating or conditional test execution, so the assertion part is generated but the generate-testing-values Dagger command.

Result of the generate command for

create_extension: true
dynamic_library_path: []
expected_extensions:
    - applied: true
      name: vector
extension_control_path: []
extension_image: registry.pg-extensions:5000/pgvector-testing:0.8.1-18-trixie
extensions:
    - name: vector
      version: 0.8.1
image_name: pgvector
ld_library_path: []
name: pgvector
pg_image: ghcr.io/cloudnative-pg/postgresql:18-minimal-trixie
shared_preload_libraries: []
sql_name: vector
version: 0.8.1

fixes #85

@mbiagetti mbiagetti requested review from a team and NiccoloFei as code owners January 29, 2026 16:28
Comment on lines -7 to -10
extensions:
- applied: true
name: ($values.sql_name)
observedGeneration: 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it because when create_extension = false, the Database CR status doesn't have an extensions field at all - it's completely omitted by Kubernetes, not returned as an empty array. So asserting extensions: [] would fail. Let me know if I should dig in the testing framework to improve this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make CREATE EXTENSION tests optional

1 participant