feat(ui): add alignRight to DataGridToolbar#1515
feat(ui): add alignRight to DataGridToolbar#1515guoda-puidokaite wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: b05f9bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
packages/ui-components/src/components/DataGridToolbar/DataGridToolbar.stories.tsx
Fixed
Show fixed
Hide fixed
packages/ui-components/src/components/DataGridToolbar/DataGridToolbar.stories.tsx
Fixed
Show fixed
Hide fixed
packages/ui-components/src/components/DataGridToolbar/DataGridToolbar.stories.tsx
Fixed
Show fixed
Hide fixed
| export const Default: Story = { | ||
| render: (args: DataGridToolbarProps) => ( | ||
| <DataGridToolbar {...args}> | ||
| <button>Add</button> |
There was a problem hiding this comment.
Please use a <Button> for this story (component instead of native button).
There was a problem hiding this comment.
Something we didn't notice in the past, done. Thanks.
|
|
||
| export const ComplexLayout: Story = { | ||
| render: (args: DataGridToolbarProps) => ( | ||
| <DataGridToolbar {...args}> |
There was a problem hiding this comment.
Please adjust this so that the searchbox is aligned to the right, everything else to the left (as in our pattern that we use in apps often.
|
|
||
| export const ComplexLayoutAlignLeft: Story = { | ||
| render: (args: DataGridToolbarProps) => ( | ||
| <DataGridToolbar {...args}> |
There was a problem hiding this comment.
Please remove this story, or remove the SearchInput from it. If we wanted to place all of these components in a toolbar we would separate them left and right as above.
Summary
Introduced an
alignRightprop for theDataGridToolbarcomponent, enhancing layout flexibility by allowing users to control the alignment of toolbar content.Changes Made
alignRightprop to theDataGridToolbarcomponent.ml-autoclass based on thealignRightvalue.alignRightprop functionality.Related Issues
Closes #1051
Testing Instructions
See Storybook.
Checklist
PR Manifesto
Review the PR Manifesto for best practises.