Skip to content

release-25.2: npgsql: remove setup dep on flaky Snap Store#169853

Merged
trunk-io[bot] merged 1 commit intocockroachdb:release-25.2from
bghal:blathers/backport-release-25.2-169836
May 7, 2026
Merged

release-25.2: npgsql: remove setup dep on flaky Snap Store#169853
trunk-io[bot] merged 1 commit intocockroachdb:release-25.2from
bghal:blathers/backport-release-25.2-169836

Conversation

@bghal
Copy link
Copy Markdown
Contributor

@bghal bghal commented May 6, 2026

Backport 1/1 commits from #169836 on behalf of @bghal.


The dependency caused the test to fail on multiple
branches. This change moves to Microsoft's install
script.

Epic: none
Fixes: #169533
Fixes: #169546
Fixes: #169547
Fixes: #169551
Fixes: #169576

Release note: None


Release justification: Change to non-production test code.

The dependency caused the test to fail on multiple
branches. This change moves to Microsoft's install
script.

Epic: none
Fixes: cockroachdb#169533
Fixes: cockroachdb#169546
Fixes: cockroachdb#169547
Fixes: cockroachdb#169551
Fixes: cockroachdb#169576

Release note: None
@bghal bghal requested review from a team as code owners May 6, 2026 19:10
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 6, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 6, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 6, 2026

😎 Merged successfully - details.

@blathers-crl blathers-crl Bot requested a review from rafiss May 6, 2026 19:10
@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels May 6, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl Bot added the backport-test-only Used to denote the backport has only non-production changes label May 6, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 6, 2026

✅ PR #169853 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: This PR modifies a file (npgsql.go) within a development tools directory (pkg/cmd/roachtest/), which is considered non-production. Under the current backport policy, changes to non-production code, tests, or development tools are exempt from the standard backport requirements. This specific change addresses an issue with a dependency causing the test to fail across multiple branches. The 'Release justification' line in the PR body explicitly states that the change is to non-production test code, which further supports exemption from standard backport requirements.

ENGREQ Check Skipped: Test-only backport.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@trunk-io trunk-io Bot merged commit 17f6e81 into cockroachdb:release-25.2 May 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-25.2.19

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants