release-25.2: ui/cluster-ui: add optional headers to jobs/databases pages#169867
release-25.2: ui/cluster-ui: add optional headers to jobs/databases pages#169867janmorales7 wants to merge 4 commits intocockroachdb:release-25.2from
Conversation
Make the page header optional via a `isEmbedded` prop on both `JobsPage` and `DatabasesPageV2`, allowing parent components to suppress the heading when embedding these pages in other layouts. Move the "Auto stats collection" toggle from the `PageHeader` actions slot into the `PageConfig` filter bar on the databases page so it sits alongside other page-level controls. A local stylesheet (`databasesPageRoot.module.scss`) is introduced to add `margin-top: 10px` on the content section below `PageConfig`. This compensates for the shared `PageConfig` container's `margin-bottom: -10px` (a sticky-header spacing trick) without modifying the shared stylesheet that affects 16+ pages. Epic: none Release note: None
Release note: None Epic: none
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
Fix prettier formatting error in conditional JSX rendering. Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
|
❌ PR #169867 does not comply with backport policy Confidence: high ✅ ENGREQ Check Passed: No ENGREQ required (non-production code or serious issues). 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Informs: CNSL-2186
Backport 1/1 commits from #169819.
/cc @cockroachdb/release
Make the page header optional via a
showHeaderprop on bothJobsPageandDatabasesPageV2, allowing parent components to suppress the heading when embedding these pages in other layouts.Move the "Auto stats collection" toggle from the
PageHeaderactions slot into thePageConfigfilter bar on the databases page so it sits alongside other page-level controls.A local stylesheet (
databasesPageRoot.module.scss) is introduced to addmargin-top: 10pxon the content section belowPageConfig. This compensates for the sharedPageConfigcontainer'smargin-bottom: -10px(a sticky-header spacing trick) without modifying the shared stylesheet that affects 16+ pages.Release justification: UI-only changes for embedded page support - no user-facing functionality changes, just optional prop for embedded layouts.