sstable: treat NumDeletionsThreshold as inclusive for tombstone-dense blocks#6013
Open
cuiweixie wants to merge 1 commit intocockroachdb:masterfrom
Open
sstable: treat NumDeletionsThreshold as inclusive for tombstone-dense blocks#6013cuiweixie wants to merge 1 commit intocockroachdb:masterfrom
cuiweixie wants to merge 1 commit intocockroachdb:masterfrom
Conversation
… blocks
Previously `maybeIncrementTombstoneDenseBlocks` in both writers compared `numDeletions > NumDeletionsThreshold`, so a block with exactly `NumDeletionsThreshold` point tombstones was not counted toward `NumTombstoneDenseBlocks`.
Use `>=` so behavior matches the documented definition ("at least `N` point tombstones") in `docs/RFCS/20240701_tombstone_density_heuristic.md`, `sstable/properties.go`, and `Options.Experimental.NumDeletionsThreshold`.
Member
|
This change is |
sumeerbhola
reviewed
May 6, 2026
Collaborator
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
@sumeerbhola reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on cuiweixie).
-- commits line 6 at r1:
This > vs >= for configuration thresholds is probably present in a bunch of places. For example, DeletionSizeRatioThreshold seems to have the same inconsistency.
I'd rather change the commentary instead of the code. For example,
// NumDeletionsThreshold defines the number of point tombstones
// that must be exceeded in a single data block for that block to be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
maybeIncrementTombstoneDenseBlocksin both writers comparednumDeletions > NumDeletionsThreshold, so a block with exactlyNumDeletionsThresholdpoint tombstones was not counted towardNumTombstoneDenseBlocks.Use
>=so behavior matches the documented definition ("at leastNpoint tombstones") indocs/RFCS/20240701_tombstone_density_heuristic.md,sstable/properties.go, andOptions.Experimental.NumDeletionsThreshold.