[break] fix(animation): separate scene dirty state from clip dirty state - #822
Open
knoxHuang wants to merge 4 commits into
Open
[break] fix(animation): separate scene dirty state from clip dirty state#822knoxHuang wants to merge 4 commits into
knoxHuang wants to merge 4 commits into
Conversation
knoxHuang
force-pushed
the
codex/animation-dirty-state-separation
branch
from
August 4, 2026 10:00
2addb85 to
7b4308f
Compare
knoxHuang
force-pushed
the
codex/animation-dirty-state-separation
branch
from
August 6, 2026 02:31
6436ea4 to
ad6a305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Background
Animation Editor edits are scoped to an Animation Clip, but the previous dirty-state reporting and save behavior could treat the shared scene undo state as the clip state. This made it difficult for the host editor to distinguish unsaved clip changes from unsaved scene changes and could route Animation Editor saves through scene saving.
✨ Changes
sceneDirtyseparately from Animation ClipdirtyinIAnimationStateInfo.💡 Design Notes
sceneDirtyis owned by the Animation service because it depends on the active animation session, its entry baseline, and the animation undo scope. The generic Undo service remains generic; the Animation service exposes the scope-aware result throughanimation.query-state().The Animation service is also the source of truth for whether an operation pushed animation-scoped Undo history; consumers must not infer this from operation success alone.
🧪 QA Steps
.animtarget. Verify that a clip asset is created at the selected target and the Scene is not saved.Risks
Focused CLI validation passed: 2 suites and 26 tests for the dirty-state/save behavior. Focused coverage for the newly included undo-history contract is blocked locally because the installed native
glbinary was built for a different Node.js ABI; full-suite CI validation is still required.