Skip to content

docs(skill): simplify obsolete test cleanup #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeaholicguy merged 1 commit into from
Aug 18, 2026
Merged

docs(skill): simplify obsolete test cleanup #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions skills/simplify-implementation/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Reduce complexity with an analysis-first approach before changing code.
2. Analyze Complexity
- Identify sources (nesting, duplication, coupling, over-engineering, magic values).
- Run an existence check: can this code be deleted, delegated to the standard library, handled by a native platform feature, enforced by the database, or covered by an existing dependency?
- Apply the existence check to tests and scaffolding: remove stale, duplicate, implementation-detail-only, unused, or no-longer-relevant tests, assertions, and fixtures without unique behavioral coverage.
- Assess impact (LOC, dependencies, cognitive load, scalability blockers).

3. Apply Readability Principles
Expand Down Expand Up @@ -53,6 +54,7 @@ For each issue, apply a pattern:
| "Existing fn is close enough — I'll bend it to fit" | Wrong abstraction is costlier than duplication | Reuse only on clean fit; otherwise keep the small duplicate |

## Validation
- Preserve meaningful regression, public-contract, and interaction coverage. Update stale tests to intentional behavior; never delete tests merely to make failures pass.
- Verify no regressions, add tests for new helpers, update docs if interfaces changed.

## Output Template
Expand Down
Loading