Make event rendering faster#2316
Merged
olleolleolle merged 2 commits intocodebar:masterfrom Sep 2, 2025
Merged
Conversation
This is very unlikely to change during one request, so we can memoise it and gain some speed
This means we won't need to make the sql requests to figure out if the user is organiser or the event
jonodrew
approved these changes
Aug 30, 2025
Contributor
jonodrew
left a comment
jonodrew
left a comment
There was a problem hiding this comment.
Happy with this. At the same time, I'd like to think about how we can avoid making ActiveRecord queries from within Views where possible
Collaborator
Author
|
@olleolleolle @jonodrew could either of you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes event rendering slightly faster, by memoising
MemberPresenter#organiser?and using it to prevent unnecessary db queries (@user.event_organiser?(event))This PR overlaps slightly with @jonodrew's work in #2305, which will make this much faster.
Before
After