Remove unused Puma cluster mode configuration #2454
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the preload_app! directive and on_worker_boot block from config/puma.rb. These cluster-mode features are not used since the application runs in single-process mode (no workers configured). VERIFICATION THAT CLUSTER MODE IS NOT USED: 1. No 'workers' setting in config/puma.rb - cluster mode requires explicitly setting 'workers N' where N > 0. Without this, Puma runs in single-process mode by default. 2. No WEB_CONCURRENCY environment variable - searched entire codebase, no references found. This is Heroku's standard variable for controlling worker count. 3. Procfile uses standard single-process command: 'bundle exec puma -C config/puma.rb' with no worker-related flags. 4. No environment-specific Puma configs - only config/puma.rb exists, no production/staging overrides. 5. Environment configs (development/production/test.rb) have no Puma worker configuration. 6. The Puma 7.2.0 warning itself confirms the on_worker_boot block "will not execute in the current Puma configuration." IMPACT: - No behavior change - this code was never executing - Removes warning introduced in Puma 7.x about unused callbacks - Prepares for Puma 8.0 where on_worker_boot will be removed entirely - If cluster mode is needed in future, these are standard patterns that can be easily restored Related to codebar#2447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
preload_app!directive andon_worker_bootblock fromconfig/puma.rb. These cluster-mode features are not used since the application runs in single-process mode across all environments.This change:
on_worker_bootwill be removed entirelyVerification
Confirmed cluster mode is not in use:
workerssetting in config/puma.rb (required for cluster mode)WEB_CONCURRENCYenvironment variable in codebaseRelated
Test Plan