fix(schema.rb): remove unbacked columns added by self-check-in migrations - #2776
Merged
Conversation
…ions Removes check_in_code and source columns/indexes that are not defined by any migration on master. The only migrations that add them live on the feature/self-check-in branch (commit 1ed1a54), which has not merged. This makes db/schema.rb consistent with db/migrate again, which is a prerequisite for the migration squash in feature/squash-pre-2026-migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
check_in_codeandsourcecolumns/indexes fromdb/schema.rbthat are not backed by any migration file onmaster.Why
The only migrations that add these columns live on
feature/self-check-in(commit 1ed1a544), which has not been merged tomaster. Having them indb/schema.rbwithout corresponding migrations makes the schema inconsistent withdb/migrateand breaks the ability to replay migrations from scratch.This is a prerequisite for the migration-squash work in
feature/squash-pre-2026-migrations.Verification
ruby -c db/schema.rbpasses.db/schema.rband runningRAILS_ENV=test TEST_ENV_NUMBER=fixverify bundle exec rails db:create db:migratereproduces the committeddb/schema.rbexactly (diffis empty).Removed
events.check_in_code+ unique indexworkshops.check_in_code+ unique indexinvitations.sourceworkshop_invitations.source