fix: prevent 'None' git service in CI uploads - #790
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
git_serviceparameter could beNoneduring an upload, leading to the literal string "None" being interpolated into the upload URL. This caused a Pydantic validation error on the backend, as "None" is not a valid git service.The root cause was that the
_get_git_servicemethod in CI adapters often returnedNone(the default from the base class), forcing reliance ongit ls-remoteparsing of the remote URL. This parsing can fail in environments with non-standard or proxied git remote URLs.To fix this,
_get_git_servicehas been overridden in the following CI adapters to provide a reliable git service based on the CI environment:GithubActionsCIAdapter: Returns"github"GitlabCIAdapter: Returns"gitlab"BitbucketAdapter: Returns"bitbucket"HarnessAdapter: Attempts to parse the git service from various Harness/Drone environment variables, falling back toNoneif unsuccessful.These changes ensure that for common CI environments, a valid git service is provided, preventing the
Nonevalue from reaching the URL construction and causing the validation error.Fixes CLI-H5
This PR was automatically generated by Sentry. You can adjust this setting at any time.