Skip to content

Hint for Jobs Test Case#273

Merged
UdeshyaDhungana merged 9 commits intomainfrom
hint-job-tc
Apr 6, 2026
Merged

Hint for Jobs Test Case#273
UdeshyaDhungana merged 9 commits intomainfrom
hint-job-tc

Conversation

@UdeshyaDhungana
Copy link
Copy Markdown
Contributor

@UdeshyaDhungana UdeshyaDhungana commented Mar 27, 2026

Note

Medium Risk
Touches shared assertion/error-message plumbing used across tests, so regressions could affect many failure outputs and fixture generation behavior. Functional changes are limited to diagnostics and test harness behavior, not user-facing shell execution.

Overview
Adds support for appending an extra hint line to colored assertion error messages by extending utils.BuildColoredErrorMessage and wiring it through SingleLineAssertion/EmptyLineAssertion.

Updates the jobs builtin test case to generate a specific hint when a finished job line incorrectly includes a trailing &, and adds a new failing scenario/fixture (background_jobs_extra_ampersand) to exercise this.

Adjusts stage_bg3 to skip fixture recording/evaluation for a known timing-dependent output ordering case.

Written by Cursor Bugbot for commit 48f9c66. This will update automatically on new commits. Configure here.

@UdeshyaDhungana UdeshyaDhungana changed the title Add hint for Jobs Test Case Hint for Jobs Test Case Mar 27, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Hint message text mismatches test fixture expectation
    • Changed the ErrorHintGenerator return string from 'Finished job entry should not have a trailing ampersand' to 'Expected job entry to not have trailing ampersand' to match the test fixture expectation.

Create PR

Or push these changes by commenting:

@cursor push d1627339c4
Preview (d1627339c4)
diff --git a/internal/test_cases/jobs_builtin_response_test_case.go b/internal/test_cases/jobs_builtin_response_test_case.go
--- a/internal/test_cases/jobs_builtin_response_test_case.go
+++ b/internal/test_cases/jobs_builtin_response_test_case.go
@@ -122,7 +122,7 @@
 					return ""
 				}
 
-				return "Finished job entry should not have a trailing ampersand"
+				return "Expected job entry to not have trailing ampersand"
 			},
 		})

You can send follow-ups to this agent here.

Comment thread internal/test_cases/jobs_builtin_response_test_case.go Outdated
Comment thread internal/stage_bg3.go
return err
}

// Fixtures are inconsistent for this stage because we cannot guarantee
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context on this: https://github.com/codecrafters-io/shell-tester/actions/runs/23781348969/job/69294613752.

There is no way to guarantee if the first 'cat' job will have been reaped or not by the time we print the logs.

@UdeshyaDhungana UdeshyaDhungana merged commit 7b2ca2f into main Apr 6, 2026
7 checks passed
@UdeshyaDhungana UdeshyaDhungana deleted the hint-job-tc branch April 6, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants