feat: Support file uploads in feature tests - #10574
Open
wakqasahmed wants to merge 3 commits into
Open
wakqasahmed wants to merge 3 commits into
wakqasahmed wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
michalsn
approved these changes
Sep 21, 2026
| * | ||
| * @return $this | ||
| */ | ||
| public function withFiles(array $files) |
Member
There was a problem hiding this comment.
Add a static return type for this?
Contributor
Author
There was a problem hiding this comment.
Done, added the static return type in 1e0104d.
paulbalandan
changed the title
carson-codeigniter4
Bot
removed
the
enhancement
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added
withFiles()so a feature test can attachMockUploadedFileobjects to its next request. The request exposes them throughgetFile()and file validation, sets a multipart content type, and clears the files before the following request. The mock uses a local file formove()andstore()while normal uploads still use PHP'smove_uploaded_file().The route-level test covers file access,
uploadedvalidation, form fields, the content type, and moving the file. A second request confirms that the attached file does not carry over. The existing upload move tests also pass.Fixes #7987.
Checklist: