🤖 fix: improve workspace default runtime UX#2553
Conversation
- Rename 'configure' to 'set defaults' with accent color styling - Pass project scope when opening Settings → Runtimes - Add '(modified)' badge when runtime differs from default - Show runtime options in Settings → Runtimes page - Add options field to RuntimeUiSpec for single-ownership RFC: rfc/260223_workspace-default-runtime.md
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6448952e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
fix/workspace-default-runtime-ux
branch
2 times, most recently
from
c46ea18 to
c6c77db
Compare
|
@codex review Reworked per RFC feedback:
|
ammar-agent
force-pushed
the
fix/workspace-default-runtime-ux
branch
from
c6c77db to
9adf786
Compare
|
@codex review Fixed: the effect now keeps the hint alive until the project appears in |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ammar-agent
force-pushed
the
fix/workspace-default-runtime-ux
branch
from
9adf786 to
9275f7a
Compare
- Rename 'configure' to 'set defaults' with accent color styling - Pass project scope when opening Settings → Runtimes (bug fix) - Style 'set defaults' button distinctly when runtime differs from default - Add configurable runtime option inputs (SSH host, Docker image, etc.) in Settings → Runtimes page for per-project scope - Add options field to RuntimeUiSpec for single-ownership RFC: rfc/260223_workspace-default-runtime.md
ammar-agent
force-pushed
the
fix/workspace-default-runtime-ux
branch
from
9275f7a to
dbb794d
Compare
|
@codex review Follow-up updates:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbb794d65d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- reuse a shared RuntimeConfigInput in both creation controls and Settings → Runtimes - add visible runtime option labels in project-scope defaults for parity with new workspace UI - remove the hyphen delimiter and restyle "set defaults" as a subtle secondary button --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$13.73`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=13.73 -->
|
@codex review |
- clear one-shot runtimesProjectPath when switching away from the runtimes section - clear runtimes scope hint on close transitions so it cannot leak across settings sessions - keep providers/runtimes hint state explicitly one-shot and section-scoped --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$13.73`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=13.73 -->
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
- update RFC 260223 notes for the latest runtime defaults UX implementation details - keep implementation/documentation context aligned in the active PR branch --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$13.73`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=13.73 -->
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
Summary
Improves the workspace default runtime UX per RFC
rfc/260223_workspace-default-runtime.md, addressing gaps left by #2387.Background
Commit 88a2be8 (#2387) moved the per-project default runtime setting from a simple tooltip checkbox into a dedicated Settings → Runtimes page. This left two UX gaps:
Implementation
Bug fix — project scope passthrough:
SettingsContextwith aruntimesProjectPathone-shot hint (same pattern as the existingprovidersExpandedProvider)Rename + prominence:
text-accentas the base stateModified state indicator (no layout shift):
bg-warning/15 text-warningpill stylerounded-sm px-1padding in both states to avoid any layout shiftConfigurable runtime options in Settings:
RUNTIME_OPTION_FIELDSconstant mapping each runtime to its configurable field (SSH→host, Docker→image, Devcontainer→configPath)lastRuntimeConfig:{projectPath}localStorage keys the creation flow usesRuntimeUiSpec.optionsSingle-ownership (RuntimeUiSpec):
options?: stringfield toRuntimeUiSpecfor centralized documentation of what each runtime requiresRisks
usePersistedState({ listener: true })Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$8.39