refactor: fileBrowser script can handle multiple runs - #1038
Open
Harsh9485 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes : #932
I added a check to see if a filebrowser process is already running, if a process found, the script verifies whather the
FB_DATABASEenvironment variable matches the current database path, if it matches, it mean file Browser is already configured and running for same database, so there's no need to configure it again. the script exits early instead of running the configuration a second time.Type of Change
Module Information
Path:
registry/coder/modules/filebrowerNew version:
v1.1.6Breaking change: [x] Yes [ ] No
Testing & Validation
bun test)bun fmt)Screenshots