fix(jupyter): bind notebook services to loopback by default#938
Open
Edd88-pixel wants to merge 1 commit into
Open
fix(jupyter): bind notebook services to loopback by default#938Edd88-pixel wants to merge 1 commit into
Edd88-pixel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jupyter authentication is disabled in these modules because access is expected
to pass through Coder. However, both services were bound to every network
interface, which could allow workloads on the same network to bypass the Coder
application proxy.
This change:
hostinput tojupyter-notebookandjupyterlab;hostto127.0.0.1;shell-unsafe characters;
healthcheck, configuration, installers, and logging behavior;
0.0.0.0as an explicit, less secure override for advanced usecases.
Type of Change
Module Information
Paths:
registry/coder/modules/jupyter-notebookregistry/coder/modules/jupyterlabNew versions:
v1.3.0for both modulesBreaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Executed:
bun installbun run fmtbun run tftestbun run tstestterraform init -upgrade,terraform validate,terraform test -verbose, andbun test main.test.tsin each affectedmodule
./scripts/terraform_validate.shwith explicitALL_CHANGED_FILESandMODULE_CHANGED_FILESbun run shellcheckfor both modified launch scripts.github/scripts/version-bump.sh minor.github/scripts/version-bump.sh --ci minor origin/mainss, confirming Jupyter Notebook on127.0.0.1:19999and JupyterLab on127.0.0.1:19998Related Issues
Closes #585