feat: Update promotions for Elementor One #329
+208
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Amazing work @rami-elementor ! |
imantsk
changed the title
sheabunge
requested changes
Jan 20, 2026
Member
There was a problem hiding this comment.
This file seems a little redundant – we can just initialise Promotions\Elementor from Plugin.
| <?php | ||
| namespace Code_Snippets; | ||
|
|
||
| if ( ! defined( 'ABSPATH' ) ) { |
Member
There was a problem hiding this comment.
We don't need to include these checks in class files.
| <?php | ||
| namespace Code_Snippets\Promotions; | ||
|
|
||
| if ( ! defined( 'ABSPATH' ) ) { |
| * @return void | ||
| */ | ||
| public function promotion_in_custom_code_screen() { | ||
| if ( ! $this->is_custom_code_screen() ) { |
Member
There was a problem hiding this comment.
We should also check if the 'hide upsell' setting is turned on before printing promos.
| <div class="notice notice-info is-dismissible code-snippets-promotion"> | ||
| <div class="code-snippets-promotion-icon"> | ||
| <img | ||
| src="<?php echo esc_url( plugins_url( 'assets/icon.svg', CODE_SNIPPETS_FILE ) ); ?>" |
| <?php esc_html_e( 'Code Snippets Pro provides a powerful and user-friendly alternative to Elementor Custom Code, with cloud sync, advanced features, and an intuitive interface.', 'code-snippets' ); ?> | ||
| </p> | ||
| <p> | ||
| <a href="<?php echo esc_url( admin_url( 'admin.php?page=snippets' ) ); ?>" class="button button-primary"> |
Member
There was a problem hiding this comment.
Please use Plugin::get_menu_url
|
|
||
| if ( $this->is_code_snippets_pro() ) { | ||
| $link_text = esc_html__( 'Manage CSS snippets', 'code-snippets' ); | ||
| $url = admin_url( 'admin.php?page=snippets&type=css' ); |
Member
There was a problem hiding this comment.
Same as above – please use API function for building URLs.
| * @return bool | ||
| */ | ||
| private function is_code_snippets_pro(): bool { | ||
| return defined( 'CODE_SNIPPETS_PRO' ) && CODE_SNIPPETS_PRO; |
Member
There was a problem hiding this comment.
This is unreliable – please use Licensing::is_licensed to check the plugin variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elementor released a new design in WordPress admin, with updated slugs. Promotions for CS should be displayed in the new Custom Code screens.
Promotion in empty archive:
Promotion in archive with custom code:
Promotion in new custom code:
