fix(affected): honor custom filter glob semantics - #1273
Conversation
|
Drive-by note from #1507, in case it helps this get looked at: this PR also fixes a bug nobody has connected to it. #1507 (opened today) reports I ran both predicates against the same inputs at
The JVM/Swift CamelCase shapes ( The one gap: your two new tests are both Python, so nothing here would catch a Go regression. If you'd like, I can send a commit adding |
|
Thanks for the careful validation and for connecting this to #1507. Please go ahead and add math.go / math_test.go regression coverage to this branch — I agree it should be included before merge. |
|
Hi @maxmilian, thanks again for offering to add the Go regression coverage. Just checking in — are you still planning to send the follow-up commit for math.go / math_test.go? No worries if timing is tight; I’m happy to add it on my side instead. Please let me know if you need anything from me to help move this forward. |
|
Hi @colbymchenry, I noticed #1507 was closed via #1803, based on #1688. My PR #1273 has been open since July 13 and already proposed replacing the duplicated test-file detection. On August 5, @maxmilian verified that it also fixes #1507 and linked it in both discussions. Could you review this earlier contribution and clarify how it should be acknowledged? My PR also includes a separate Thanks. |
codegraph affected --filter 'tests/**/*.py'misses tests directly insidetests/, while--filter 'tests/*.py'can also selectother/tests/...or a changed.py.bakfile. This change uses the existingpicomatchdependency to match glob patterns correctly.Filters containing
/match the whole project-relative path, and**/matches zero or more directories. Filename-only filters such as*_test.gocontinue to match at any depth, and explicit custom filtering still includes dotfiles.This PR now focuses on the remaining custom-filter fix from #1273. The default test-file recognition is already covered by #1803; its shared
isTestPathclassifier and existing Go/Python/JVM regression tests are retained. The branch is synchronized withmainand preserves the original contribution history.Validation
npm run buildpassed on Windows with Node 24.14.1.cli-affected-filter,cli-affected-paths,cli-affected-test-conventions,is-test-file, andgraph.git diff --checkpassed.npm auditreports 10 existing dependency advisories (1 critical, 4 high, 5 moderate). Dependency manifests and lockfiles match upstream; this PR adds or updates no dependencies.