fix(extraction): retain nested call evidence without guessed targets - #1844
Open
bompus wants to merge 1 commit into
Open
fix(extraction): retain nested call evidence without guessed targets#1844bompus wants to merge 1 commit into
bompus wants to merge 1 commit into
Conversation
Keep JS/TS nested call-site text for Steps and framework resolution, and refuse last-name guesses that bound Map.get/set/has to unrelated project methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1790 stopped
Map.get/set/hasfrom resolving to unrelated project methods by dropping nested identifier calls entirely. That also removed call-site evidence Steps and framework resolution need, so chains such asholder.values.get(readKey())kept the argument call but lost the nested member.This change keeps the full nested receiver text, including optional access, computed keys, and comments. Framework resolvers can still bind a proven target. Generic import and last-name matching will not treat an imported root or an unrelated
getas the called member. Simplenew Map()receivers still stay off project methods, and a project class that legitimately shadowsMapstill resolves. Rebuild existing indexes after this lands (extraction version 26 → 27).Fixes #1794.
Related: #1566, #1790.
Validation
Based on upstream
3ed73bc127323e63153bf6ec8354afa82ce36aaf; head95dccf90contains only this fix and its tests.kernel-tsjs-parity,resolution, andts-chained-receiverwithCODEGRAPH_KERNEL_EXPECT=1and one worker. The sameresolutionandts-chained-receiversuites passed 218 tests withCODEGRAPH_KERNEL=0. TypeScript compilation and diff whitespace checks passed.check:agent-docsis a fork-only script and was not run on this branch.61f73f20, including this behavior and other fork changes: 4,778 native tests and 4,776 WASM tests passed, zero failures; all five downstream source probes passed. Those are integration results, not a full-suite run of this exact PR branch.