Skip to content

feat(frameworks): add angular support (@comark/angular)#178

Open
arashsheyda wants to merge 20 commits into
mainfrom
feat/angular
Open

feat(frameworks): add angular support (@comark/angular)#178
arashsheyda wants to merge 20 commits into
mainfrom
feat/angular

Conversation

@arashsheyda

@arashsheyda arashsheyda commented May 5, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

closes #176

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this PR adds official support of Comark for Angular (POC at least)

📝 Checklist

  • I have linked an issue or discussion.
  • I have run pnpm verify and it passes.
  • I have updated the documentation accordingly.

@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comark Ready Ready Preview Jun 13, 2026 2:22am
comark-json-render Ready Ready Preview Jun 13, 2026 2:22am
comark-nextjs Error Error Jun 13, 2026 2:22am
comark-nuxt Ready Ready Preview Jun 13, 2026 2:22am
comark-svelte Error Error Jun 13, 2026 2:22am
comark-sveltekit Ready Ready Preview Jun 13, 2026 2:22am
comark-twoslash Error Error Jun 13, 2026 2:22am
comark-vue Error Error Jun 13, 2026 2:22am

@pkg-pr-new

pkg-pr-new Bot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comarkdown/comark@178

@comark/angular

npm i https://pkg.pr.new/comarkdown/comark/@comark/angular@178

@comark/ansi

npm i https://pkg.pr.new/comarkdown/comark/@comark/ansi@178

@comark/html

npm i https://pkg.pr.new/comarkdown/comark/@comark/html@178

@comark/nuxt

npm i https://pkg.pr.new/comarkdown/comark/@comark/nuxt@178

@comark/react

npm i https://pkg.pr.new/comarkdown/comark/@comark/react@178

@comark/svelte

npm i https://pkg.pr.new/comarkdown/comark/@comark/svelte@178

@comark/vue

npm i https://pkg.pr.new/comarkdown/comark/@comark/vue@178

commit: 36afd40

@atinux

atinux commented May 21, 2026

Copy link
Copy Markdown
Contributor

any blocker/updates on this @arashsheyda ?

@arashsheyda

Copy link
Copy Markdown
Collaborator Author

@atinux no I tested it and was working, just wanted to get the input from angular users (the person who opened the issue) will do a review tonight and mark it as ready

@atinux

atinux commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Amazing work @arashsheyda !

Could you please add the sideEffects: false as well (see #228) ?

Also, could you also add a component in the examples using slots? like https://github.com/comarkdown/comark/blob/main/examples/1.frameworks/nextjs/components/FeatureCard.tsx

@arashsheyda

Copy link
Copy Markdown
Collaborator Author

@atinux updated! thanks

Comment thread packages/comark-angular/package.json Outdated
@farnabaz

Copy link
Copy Markdown
Contributor

Thanks for the PR @arashsheyda,
I tried to run the example but it raise and error:

[plugin:@analogjs/vite-plugin-angular:template-class-binding-guard] [Analog Angular] Selectorless component detected.
File: /Users/far/projects/comark/packages/comark-angular/src/define.ts
Component: DefinedComarkComponent
This component has no selector, so Angular will render it as ng-component.
That increases the chance of component ID collisions and makes diagnostics harder to interpret.
Add an explicit selector for reusable components.
Selectorless components are only supported for page and route-only files.

Screenshot 2026-06-12 at 14 29 09

Did I missed something?

@arashsheyda

Copy link
Copy Markdown
Collaborator Author

@farnabaz oops I broke it with my latest commits, fixing it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Angular (17+)

4 participants