Merged
Conversation
This is simply updating the RealtimeDatabase class to take paths instead the previous API for children and reference names.
This is updating to a path based reference other than making something that uploads the previous child based methods.
This includes updating the Project Manager class to the path based referencing.
Member
|
@jckenny59 Could you please change base to |
This is updating the method signatures in the overall class. As most of this had to be undone in the conflict resolution.
This is simple as well, and does the same to update method signatures in because of conflict resolution.
Collaborator
Author
|
@gonzalocasas taken care of, and updated method formatting after my merge conflict :) |
gonzalocasas
approved these changes
Mar 27, 2026
Member
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
lgtm + a few smaller details here and there
Comment on lines
+161
to
+163
| # TODO: Check if this is stupid... it provides the functionality of making it work with compas objects and consistency across both child classes | ||
| json_string = json_dumps(data) | ||
| database_reference.set(json.loads(json_string)) |
This is simple, removing information in doc strings because of the type hint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Summary
This PR refactors Firebase access to a path-based API across RealtimeDatabase and Storage, and updates ProjectManager to use the new path-based calls.
Key changes:
RealtimeDatabasenow uses path-based operations as the primary API.Storagenow uses path-based operations as the primary API.ProjectManagercall sites were migrated away from removed deep/child/list helper methods.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.Notes
This PR is marked as breaking because legacy child/deep/list APIs were removed in favor of path-based APIs.
Callers now need to use path strings with the new method surface.
Affected components:
realtime_database.pystorage.py_path.pyproject_manager.pyValidation scope:
I did not run the full project test suite or lint suite yet (for example invoke test / invoke lint).