feat(12factor-env): opt-in dotenv support - #1717
Closed
pyramation wants to merge 1 commit into
Closed
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Superseded by a correctly-named branch PR (branch naming convention). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context: constructive-planning#1645 —
@agentic-kit/pihard-codesreadFile(path.join(cwd, '.env'))with a hand-rolled dotenv parser as the only config lane. This gives12factor-enva canonical home for the "environment first,.envas a local-dev convenience" rule so packages stop re-deriving it.Purely additive — nothing about
env()/cleanEnvchanges, and no.envis read unless you call the new helper:Key semantics:
override: trueflips it for desktop-style "the project file is the source of truth" hosts.util.parseEnv(Node ≥20.12; repo requires 22) — no new dependency, no hand-rolled parser. Exported asparseDotenv(source)for direct use (e.g. to replace pi's localparseEnv).Follow-up (separate PR, tracked in #1645): migrate
agentic/pi/src/context.tsontodotenv({ cwd, environment: {}, override: true })/ injectable resolvers so headless hosts can useprocess.env.Link to Devin session: https://app.devin.ai/sessions/450ce6d6659c47759c184ae6ec19a2a8
Requested by: @pyramation