Add configurable Grafast cache limits - #1746
Draft
Zetazzz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements planning item F06 on top of the reusable performance harness in #1716.
Configuration
{ "graphile": { "grafastCache": { "queryCacheMaxLength": 512, "operationsCacheMaxLength": 256, "operationOperationPlansCacheMaxLength": 32 } } }Equivalent environment variables:
GRAPHILE_QUERY_CACHE_MAX_LENGTHGRAPHILE_OPERATIONS_CACHE_MAX_LENGTHGRAPHILE_OPERATION_PLANS_CACHE_MAX_LENGTHValidation
Passed:
@constructive-io/graphql-envtests: 28 tests@constructive-io/graphql-servertests: 143 testspnpm install --frozen-lockfilegit diff --checkThe full graphile-settings run passed 7 of 8 suites (67 tests). Its preset-integration suite has 29 PostgreSQL failures because the local test role lacks permission for schema
integration_test. The exact same 29 failures were reproduced on the unchanged base commit6500d408e9f0e2240f7272869f0f15bf6d12e1fa, so this is a base/environment issue rather than an F06 regression.Refs constructive-io/constructive-planning#1693.