Skip to content

test: de-parallelize TestRunQuiet so it stops GC'ing the shared image #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 1 commit into from
Jun 25, 2026
Merged

test: de-parallelize TestRunQuiet so it stops GC'ing the shared image #4998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/nerdctl/container/container_run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,11 @@ func TestRunAttachFlag(t *testing.T) {
func TestRunQuiet(t *testing.T) {
testCase := nerdtest.Setup()

// This test removes the shared image to force a fresh pull, so it must not
// run alongside other tests that use it: the content store is global across
// namespaces, so the rmi would GC layers out from under a parallel run.
testCase.NoParallel = true

testCase.Setup = func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rmi", "-f", testutil.CommonImage)
}
Expand Down
Loading