feat: label-based filtering added to nerdctl events#4999
Open
Mujib-Ahasan wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
|
|
||
| eOut := EventOut{e.Timestamp, id, e.Namespace, e.Topic, TopicToStatus(e.Topic), string(out)} | ||
| if id != "" { | ||
| container, err := client.ContainerService().Get(ctx, id) |
Contributor
There was a problem hiding this comment.
probably can improve like
if container, err := client.ConatinerService.Get(ctx, id); err == nil {
labels = container.Labels
}
AkihiroSuda
reviewed
Jun 24, 2026
Member
There was a problem hiding this comment.
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
Author
|
@AkihiroSuda there are so many failed checks and after surfacing little bit I strongly feels they are flaky and not related to the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for label-based filtering in nerdctl events. Users can now filter the event stream using container labels, for example:
Fixes: #4690
The implementation resolves container metadata from incoming events and matches the configured label filter before displaying the event. This helps users focus on events related to a specific workload in environments with so many running containers.