refactor(api)!: consolidate AccessControlClientset into Kubernetes struct #585
+247
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
changed the title
manusa
force-pushed
the
refactor/kubernetes
branch
from
42b4c73 to
62c8efb
Compare
7 tasks
…ruct The AccessControlClientset was an unnecessary layer of indirection between the KubernetesClient interface and the Kubernetes implementation. This change merges the AccessControlClientset directly into the Kubernetes struct, simplifying the architecture and reducing complexity. - Merge KubernetesClientSet interface into KubernetesClient - Move all AccessControlClientset methods to Kubernetes struct - Delete accesscontrol.go and accesscontrol_client_set.go - Rename NewAccessControlClientset to NewKubernetes - Update all callers to use Kubernetes directly BREAKING CHANGE: AccessControlClientset() method removed from KubernetesClient interface. Callers should use the KubernetesClient methods directly. Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
refactor/kubernetes
branch
from
62c8efb to
7c3b2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #578
Second phase of #577
After these changes the only thing left will be to clean up the api.KubernetesClient interface to not expose the core methods (ResourcesList, ResourcesGet, NamespacesList, etc.)
This will leave a very clean api.KubernetesClient interface powerful enough to implement any kind of toolset.
The AccessControlClientset was an unnecessary layer of indirection between the KubernetesClient interface and the Kubernetes implementation. This change merges the AccessControlClientset directly into the Kubernetes struct, simplifying the architecture and reducing complexity.
BREAKING CHANGE: AccessControlClientset() method removed from KubernetesClient interface. Callers should use the KubernetesClient methods directly.