chore: updates CI runners and handles failing Windows test#101
Conversation
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in pkg/tar-patch/apply.go where an error encountered while closing the current file was being ignored and nil was returned instead of the actual error. The code has been corrected to return the err. There are no review comments to address.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 81.43% 81.61% +0.17%
==========================================
Files 10 10
Lines 1115 1115
==========================================
+ Hits 908 910 +2
+ Misses 117 116 -1
+ Partials 90 89 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b3fbf61 to
27f0279
Compare
cdbe4e8 to
1b77c2a
Compare
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
…ion for broader compatibility Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
2fe3ca6 to
9810239
Compare
djach7
left a comment
There was a problem hiding this comment.
A couple of change requests, thanks for working on this!
9810239 to
4083ba4
Compare
knecasov
left a comment
There was a problem hiding this comment.
I added some comments.
A note regarding removing toolchain go1.26.2 in the PR description would help future readers understand the rationale.
I think that in the sentence "This PR temporarily skips an issue where Windows builds fails...", there should be "fail" instead of "fails".
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
4083ba4 to
f677306
Compare
knecasov
left a comment
There was a problem hiding this comment.
LGTM, thank you very much for incorporating the notes!
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR temporarily skips an issue where Windows builds fails when source files are missing. It also cleans up our CI workflow by removing unsupported platforms.
Tests
niltoerrand adds a new test function for the added error path to satisfy Codecov patch % requirement.Chores
-Removes
toolchain go1.26.2so to ensure only stable versiongo1.26is usedgo.modandREADME.mdbadge with Go 1.26 for version stabilityCloses #84