Skip to content

chore: updates CI runners and handles failing Windows test#101

Merged
djach7 merged 3 commits into
containers:mainfrom
rosygmiki:windows-system-test
Jun 16, 2026
Merged

chore: updates CI runners and handles failing Windows test#101
djach7 merged 3 commits into
containers:mainfrom
rosygmiki:windows-system-test

Conversation

@rosygmiki

@rosygmiki rosygmiki commented May 27, 2026

Copy link
Copy Markdown
Collaborator

This PR temporarily skips an issue where Windows builds fails when source files are missing. It also cleans up our CI workflow by removing unsupported platforms.

Tests

  • Skips the missing source file test on Windows.
  • Includes a bug fix which changes nil to err and adds a new test function for the added error path to satisfy Codecov patch % requirement.

Chores

  • Removes CI workflow support for macOS on Intel and Windows on ARM.
    -Removes toolchain go1.26.2 so to ensure only stable version go1.26 is used
  • Updates go.mod and README.md badge with Go 1.26 for version stability

Closes #84

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in pkg/tar-patch/apply.go where an error encountered while closing the current file was being ignored and nil was returned instead of the actual error. The code has been corrected to return the err. There are no review comments to address.

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.61%. Comparing base (752790f) to head (f677306).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   81.43%   81.61%   +0.17%     
==========================================
  Files          10       10              
  Lines        1115     1115              
==========================================
+ Hits          908      910       +2     
+ Misses        117      116       -1     
+ Partials       90       89       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosygmiki rosygmiki changed the title fix: returns error when closing call fails - resolves potential bug fix: validate source files exist before applying patch Jun 2, 2026
@rosygmiki rosygmiki force-pushed the windows-system-test branch 4 times, most recently from b3fbf61 to 27f0279 Compare June 3, 2026 20:14
@rosygmiki rosygmiki force-pushed the windows-system-test branch from cdbe4e8 to 1b77c2a Compare June 12, 2026 13:10
@rosygmiki rosygmiki changed the title fix: validate source files exist before applying patch chore: updates CI runners and handles failing Windows test Jun 12, 2026
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
…ion for broader compatibility

Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
@rosygmiki rosygmiki force-pushed the windows-system-test branch 3 times, most recently from 2fe3ca6 to 9810239 Compare June 12, 2026 15:47

@djach7 djach7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of change requests, thanks for working on this!

Comment thread pkg/tar-patch/apply.go
Comment thread tests/test-tar-errors.sh Outdated
@rosygmiki rosygmiki force-pushed the windows-system-test branch from 9810239 to 4083ba4 Compare June 15, 2026 13:11
@rosygmiki rosygmiki requested a review from djach7 June 15, 2026 13:13

@djach7 djach7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knecasov knecasov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

A note regarding removing toolchain go1.26.2 in the PR description would help future readers understand the rationale.

I think that in the sentence "This PR temporarily skips an issue where Windows builds fails...", there should be "fail" instead of "fails".

Comment thread pkg/tar-patch/apply.go Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread pkg/tar-patch/apply_test.go
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
@rosygmiki rosygmiki force-pushed the windows-system-test branch from 4083ba4 to f677306 Compare June 15, 2026 18:48
@rosygmiki rosygmiki requested a review from knecasov June 15, 2026 18:48

@knecasov knecasov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for incorporating the notes!

@djach7 djach7 merged commit 310a9bb into containers:main Jun 16, 2026
12 checks passed
@semanticreleasebot-rmiki

Copy link
Copy Markdown

🎉 This PR is included in version 0.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System tests for Window compatibility

3 participants