Additional work on tools/call and resources/read - #118
Open
dawid-nowak wants to merge 7 commits into
Open
Conversation
…filter by tool name, resource uri Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Fixing unit tests Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Adding extra tests Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Adding extra tests.2 Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
dawid-nowak
requested review from
cafalchio,
gandhipratik203,
lucarlig and
madhu-mohan-jaishankar
and removed request for
lucarlig and
madhu-mohan-jaishankar
August 26, 2026 15:26
lucarlig
requested changes
Aug 27, 2026
lucarlig
reviewed
Aug 27, 2026
…d tools and resources due to overlap with aliases Signed-off-by: Dawid Nowak <nowakd@gmail.com>
lucarlig
reviewed
Aug 27, 2026
| @@ -39,60 +34,36 @@ pub(super) fn resolve_tool_route<'a, N: AsRef<str>>( | |||
| alias.or_else(|| route_identifier(name, backend_names)) | |||
Contributor
There was a problem hiding this comment.
Alias misses bypass filtering. Route only configured aliases.
Suggested change
| alias.or_else(|| route_identifier(name, backend_names)) | |
| alias |
| Implementation::new("contextforge-data-plane", env!("CARGO_PKG_VERSION")), | ||
| ) | ||
| .with_protocol_version(ProtocolVersion::V_2026_07_28); | ||
| .with_protocol_version(backend.mcp_protocol_version.clone()); |
Contributor
There was a problem hiding this comment.
Use the configured version in the lifecycle too:
ClientLifecycleMode::Auto {
preferred_versions: vec![backend.mcp_protocol_version.clone()],
legacy_version: Some(backend.mcp_protocol_version.clone()),
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.