fix(cli): keep Ollama tool calls when stream deltas omit id - #13235
Open
seethinajayadileep wants to merge 1 commit into
Open
fix(cli): keep Ollama tool calls when stream deltas omit id#13235seethinajayadileep wants to merge 1 commit into
seethinajayadileep wants to merge 1 commit into
Conversation
Some providers (notably Ollama) send the first tool_call delta with an index but no id. processToolCallDelta previously dropped those deltas. Synthesize a stable call_<index> id so argument fragments accumulate. Fixes continuedev#13225 Signed-off-by: JAYA DILEEP <seethinajayadileep@hotmail.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
seethinajayadileep
marked this pull request as ready for review
September 6, 2026 05:37
seethinajayadileep
requested review from
sestinj
and removed request for
a team
September 6, 2026 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13225
Summary
Some providers (notably Ollama with models like
gpt-oss) send the first streamingtool_callsdelta with anindexbut noid.processToolCallDelta()only created an index→id mapping whenidwas present, so the first delta was dropped and later argument fragments never accumulated. Tool args then appeared as plain assistant text and the tool never ran.Change
When a delta has
indexbut noidand no mapping yet, synthesize a stablecall_<index>id and store it inindexToIdMapso subsequent fragments attach correctly. Real provider ids are still preferred when present.Test plan