chore: create script to lead one down the right benchmark path#32
Merged
chore: create script to lead one down the right benchmark path#32
Conversation
narenandu
previously approved these changes
Feb 2, 2026
Contributor
narenandu
left a comment
narenandu
left a comment
There was a problem hiding this comment.
LGTM ! I am going to trust that this was tested already
| API_BASE="https://api.coreweave.com" | ||
|
|
||
| # Check if credentials are already set as environment variables | ||
| if [[ -n "${ACCESS_KEY_ID:-}" && -n "${SECRET_KEY:-}" ]]; then |
Contributor
There was a problem hiding this comment.
I know it's just semantics, but I am used to seeing ACCESS_KEY_ID and ACCESS_KEY_SECRET from AWS land
Suggested change
| if [[ -n "${ACCESS_KEY_ID:-}" && -n "${SECRET_KEY:-}" ]]; then | |
| if [[ -n "${ACCESS_KEY_ID:-}" && -n "${ACCESS_KEY_SECRET-}" ]]; then |
MYanello
reviewed
Feb 2, 2026
Comment on lines
+92
to
+96
| # Create a temporary AI Object Storage access key | ||
| print_info "Creating AI Object Storage access key..." | ||
|
|
||
| # Create JSON payload | ||
| JSON_PAYLOAD='{"durationSeconds": 0}' |
Contributor
There was a problem hiding this comment.
Duration 0 but you say it's temporary?
I'd think either that's a permanent key, or it expires immediately.
Contributor
Author
There was a problem hiding this comment.
It's a permanent key but strangely a temporary one didn't seem to work here
| # Get the API token from kubeconfig | ||
| echo "Extracting API token from kubeconfig..." | ||
| API_ACCESS_TOKEN=$(kubectl config view --raw -o jsonpath='{.users[0].user.token}') | ||
| API_TOKEN="${API_ACCESS_TOKEN}" |
Contributor
There was a problem hiding this comment.
Why do we do reassign this?
Contributor
Author
There was a problem hiding this comment.
because AI. Fixed.
MYanello
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.