Repository navigation
Conversation
Add ruler.sidecar.resourceName and alertmanager.sidecar.resourceName, which set RESOURCE_NAME on the k8s-sidecar containers so they only watch the listed ConfigMaps and/or Secrets. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
I added
ruler.sidecar.resourceNameandalertmanager.sidecar.resourceName. When set, the chart passes the value asRESOURCE_NAMEto the k8s-sidecar containers, so a sidecar only watches the listed ConfigMaps and/or Secrets instead of every resource that matches the label. The default is empty, so nothing changes for existing installs.This covers the ruler Deployment and both alertmanager workloads (Deployment and StatefulSet).
Which issue(s) this PR fixes:
Fixes #561
Checklist
CHANGELOG.mdupdatedNotes
I updated the README rows to match helm-docs output. The new env var uses the same pattern as the existing
RESOURCEblock, withwithso it is only rendered when a value is set.