Repository navigation
Conversation
Add httpRoute.* values that render a gateway.networking.k8s.io/v1 HTTPRoute pointing at the nginx service, as an alternative to the Ingress. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
With ingress-nginx being retired, I added an optional Gateway API
HTTPRoutefor the cortex nginx service as an alternative to the existingingressvalues.When
httpRoute.enabledis true (andnginx.enabled), the chart renders agateway.networking.k8s.io/v1HTTPRoutethat sends traffic to the nginx service on the same port the Ingress uses. The new values:httpRoute.parentRefs: the Gateway(s) to attach tohttpRoute.hostnames: hostnames (templated, like other values in the chart)httpRoute.matches: defaults toPathPrefix /, same as the Ingress defaulthttpRoute.filters,httpRoute.annotations,httpRoute.labelsIt is disabled by default, so existing installs render the same manifests.
Example:
Which issue(s) this PR fixes:
Fixes #602
Checklist
CHANGELOG.mdupdatedNotes
I kept the route to a single rule that points at nginx, because nginx already does the per-path routing to the Cortex components. I didn't enable it in the
ci/values, since the test cluster may not have the Gateway API CRDs installed.