Add unit tests for alertspb ToProto and ParseTemplates#7353
Open
archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
Open
Add unit tests for alertspb ToProto and ParseTemplates#7353archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
SungJin1212
approved these changes
Mar 17, 2026
Member
|
@archy-rock3t-cloud |
Contributor
Author
|
@SungJin1212 sure, updated |
archy-rock3t-cloud
force-pushed
the
test/alertspb-compat-unit-tests
branch
2 times, most recently
from
a4fdfcf to
889ca8f
Compare
Contributor
Author
|
@SungJin1212 please take a look at the last commit, it should fix flaky test if I understood the issue correctly |
Member
|
@archy-rock3t-cloud |
Signed-off-by: Artem Muterko <artem@sopho.tech>
archy-rock3t-cloud
force-pushed
the
test/alertspb-compat-unit-tests
branch
from
c31a621 to
4c4a00f
Compare
Contributor
Author
|
@SungJin1212 sure, here it is #7386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds unit tests for
ToProtoandParseTemplatesinpkg/alertmanager/alertspbWhich issue(s) this PR fixes:
N/A — test coverage improvement
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]