Use 202 Accepted for SetOverrides and buffer GetOverrides response#7370
Open
friedrichg wants to merge 1 commit intomasterfrom
Open
Use 202 Accepted for SetOverrides and buffer GetOverrides response#7370friedrichg wants to merge 1 commit intomasterfrom
friedrichg wants to merge 1 commit intomasterfrom
Conversation
SetOverrides writes to the object storage bucket like the ruler API, so it should return 202 Accepted to indicate the change has been stored Also buffer the GetOverrides JSON response so http.Error works correctly if encoding fails. Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
force-pushed
the
use-status-accepted
branch
from
b3990f7 to
df9b749
Compare
Member
|
LGTM, the e2e tests also need to be changed to 202. |
CharlieTLe
reviewed
Mar 29, 2026
Member
CharlieTLe
left a comment
CharlieTLe
left a comment
There was a problem hiding this comment.
DeleteOverrides also writes to the bucket via deleteOverridesFromBucket but still returns 200 OK. The same async reasoning for using 202 Accepted applies here — should this be updated too?
Changing the SetOverrides status code from 200 to 202 is a user-facing API change — clients checking == 200 would need to update. Should this have a [CHANGE] entry in the CHANGELOG?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: SetOverrides writes to the object storage bucket like the ruler API, so it should return 202 Accepted to indicate the change has been stored Also buffer the GetOverrides JSON response so http.Error works correctly if encoding fails.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]