expose SelectorBatchSize config for Thanos engine - #7763
Merged
yeya24 merged 2 commits intoAug 14, 2026
Conversation
Signed-off-by: Paurush Garg <paurushg@amazon.com>
Signed-off-by: Paurush Garg <paurushg@amazon.com>
harry671003
approved these changes
Aug 13, 2026
SungJin1212
reviewed
Aug 14, 2026
| # Changelog | ||
|
|
||
| ## master / unreleased | ||
| * [FEATURE] Engine: Add `-querier.selector-batch-size` and `-ruler.selector-batch-size` flags to configure series batching in the Thanos promQL engine. 0 disables batching. #7763 |
Member
There was a problem hiding this comment.
Thanks, could you fix the changelog ordering?
SungJin1212
approved these changes
Aug 14, 2026
yeya24
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Expose SelectorBatchSize from the Thanos promQL engine as a configurable flag for querier and ruler:
The Thanos promQL engine's SelectorBatchSize controls how many series are processed per batch in selectors. When set, the engine allocates iterators lazily per batch instead of all upfront, and for instant queries releases them after each batch. This reduces peak memory for high-cardinality queries.
thanos-io/promql-engine#721 enabled lazy iterator allocation and
SelectorBatchSizefor certain query patterns. This PR exposes it as a Cortex configuration option.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags