Skip to content

Fix log instructions for claude#4237

Merged
fafk merged 1 commit intomainfrom
fix-claude-logs
Mar 6, 2026
Merged

Fix log instructions for claude#4237
fafk merged 1 commit intomainfrom
fix-claude-logs

Conversation

@fafk
Copy link
Contributor

@fafk fafk commented Mar 6, 2026

Description

Log format has changed so I updated instructions how to use it for Claude.

@fafk fafk requested a review from a team as a code owner March 6, 2026 08:24
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation for log queries to reflect changes in the query format. I have one suggestion to improve placeholder consistency in docs/COW_ORDER_DEBUG_SKILL.md for better clarity.

Note: Security Review has been skipped due to the limited scope of the PR.

@fafk fafk force-pushed the fix-claude-logs branch from 62b4033 to 1f0e7b7 Compare March 6, 2026 09:30
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, does raise some questions in my head

I wonder if you do the following it would improve "search performance" (not speed-wise, result quality)

  1. Provide a link to the VL query language spec (something like https://docs.victoriametrics.com/victorialogs/querying/)
  2. Provide meaning mappings for labels
  3. Some examples (like you do already)

I also wonder if, instead of providing a large skills/CLAUDE.md, we provide a "tree" of files that it can get and the scenarios it should reach out for it, it would reduce the context size and thus avoid compactions

@fafk
Copy link
Contributor Author

fafk commented Mar 6, 2026

PR looks good, does raise some questions in my head

I wonder if you do the following it would improve "search performance" (not speed-wise, result quality)

  1. Provide a link to the VL query language spec (something like docs.victoriametrics.com/victorialogs/querying)
  2. Provide meaning mappings for labels
  3. Some examples (like you do already)

I also wonder if, instead of providing a large skills/CLAUDE.md, we provide a "tree" of files that it can get and the scenarios it should reach out for it, it would reduce the context size and thus avoid compactions

I think it might. So far with the "all" field it's been performing well. Claude is also very smart so it uses tail to cut the size and if there is a lot of output it writes it to a temp file and runs a python script over it to get insights. One needs to experiment with these things to see what works.

@fafk fafk added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit fb96d59 Mar 6, 2026
17 checks passed
@fafk fafk deleted the fix-claude-logs branch March 6, 2026 10:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants