Skip to content

[feat][evaluation] big obj upgrade#447

Merged
tpfz merged 10 commits intomainfrom
feat/wzq/big_obj
Mar 9, 2026
Merged

[feat][evaluation] big obj upgrade#447
tpfz merged 10 commits intomainfrom
feat/wzq/big_obj

Conversation

@tpfz
Copy link
Collaborator

@tpfz tpfz commented Mar 6, 2026

整理由多次修复/日志调整等形成的历史提交,合并为一次提交,便于回溯与发布。

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

tpfz added 3 commits March 6, 2026 14:57
整理由多次修复/日志调整等形成的历史提交,合并为一次提交,便于回溯与发布。
@tpfz tpfz force-pushed the feat/wzq/big_obj branch from 1d93614 to 8e2468b Compare March 6, 2026 06:59
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the big-object refactor. Overall the design around RecordDataStorage, S3 offloading, and on-demand loading via EvalTargetService looks consistent and safe. I left one inline comment about logging full EvaluatorInputData at info level, which may unnecessarily increase log volume and expose sensitive content.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 82.32323% with 70 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nd/modules/evaluation/infra/storage/record_data.go 79.00% 19 Missing and 19 partials ⚠️
.../modules/evaluation/application/eval_target_app.go 72.72% 5 Missing and 4 partials ⚠️
...aluation/domain/service/expt_run_item_turn_impl.go 88.46% 3 Missing and 3 partials ⚠️
...luation/infra/repo/target/eval_target_repo_impl.go 73.68% 4 Missing and 1 partial ⚠️
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% 3 Missing ⚠️
.../api/handler/coze/loop/apis/eval_target_service.go 0.00% 2 Missing ⚠️
...tion/infra/repo/evaluator/evaluator_record_impl.go 88.23% 1 Missing and 1 partial ⚠️
backend/modules/evaluation/pkg/utils/trim.go 91.66% 1 Missing and 1 partial ⚠️
backend/api/api.go 0.00% 1 Missing ⚠️
...modules/evaluation/domain/service/analysis_impl.go 0.00% 1 Missing ⚠️
... and 1 more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   73.83%   73.94%   +0.10%     
==========================================
  Files         626      627       +1     
  Lines       64821    65170     +349     
==========================================
+ Hits        47860    48189     +329     
+ Misses      13711    13700      -11     
- Partials     3250     3281      +31     
Flag Coverage Δ
unittests 73.94% <82.32%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...modules/evaluation/application/eval_openapi_app.go 92.39% <100.00%> (ø)
...nd/modules/evaluation/application/evaluator_app.go 89.17% <100.00%> (ø)
...dules/evaluation/domain/entity/evaluator_record.go 100.00% <ø> (ø)
...nd/modules/evaluation/domain/entity/expt_result.go 52.75% <ø> (ø)
.../modules/evaluation/domain/entity/target_record.go 58.53% <ø> (ø)
...s/evaluation/domain/service/evaluation_set_impl.go 93.33% <100.00%> (ø)
...luation/domain/service/evaluation_set_item_impl.go 95.18% <100.00%> (ø)
...odules/evaluation/domain/service/evaluator_impl.go 74.43% <100.00%> (+0.05%) ⬆️
...evaluation/domain/service/evaluator_record_impl.go 87.09% <100.00%> (ø)
...ation/domain/service/evaluator_source_code_impl.go 85.09% <100.00%> (+0.04%) ⬆️
... and 23 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27d2fb...f366d69. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lsy357
lsy357 previously approved these changes Mar 9, 2026
dsf86
dsf86 previously approved these changes Mar 9, 2026
@tpfz tpfz dismissed stale reviews from dsf86 and lsy357 via f366d69 March 9, 2026 06:36
@tpfz tpfz merged commit ef2619a into main Mar 9, 2026
17 checks passed
@tpfz tpfz deleted the feat/wzq/big_obj branch March 9, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants