Skip to content

Test and fix support for iostream manipulators #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 4 commits into from
Mar 24, 2026
Merged

Test and fix support for iostream manipulators #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e545891
Add testing of all the different <ios> manipulators
mborland Mar 24, 2026
acd73a5
Get streaming fix from upstream
mborland Mar 24, 2026
b814a41
Update docs with stream manipulator support
mborland Mar 24, 2026
2b06082
Remove workarounds from testing
mborland Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/modules/ROOT/pages/iostream.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ auto operator>>(std::basic_istream<charT, traits>& is, LibType& v)
| Converted to the underlying `uint128_t` and written using its stream support
|===

Standard stream manipulators (`std::hex`, `std::oct`, `std::dec`, `std::setw`, etc.) work as expected.
Standard stream manipulators (`std::hex`, `std::oct`, `std::dec`, `std::showbase`, `std::setw`, etc.) work as expected.

=== Input (`operator>>`)

Expand Down
17 changes: 10 additions & 7 deletions include/boost/safe_numbers/detail/int128/iostream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,17 @@ auto operator<<(std::basic_ostream<charT, traits>& os, const LibIntegerType& v)

auto first {detail::mini_to_chars(buffer, v, base, uppercase)};

if (base == 8)
if (flags & std::ios_base::showbase)
{
*--first = '0';
}
else if (base == 16)
{
*--first = uppercase ? 'X' : 'x';
*--first = '0';
if (base == 8)
{
*--first = '0';
}
else if (base == 16)
{
*--first = uppercase ? 'X' : 'x';
*--first = '0';
}
}

BOOST_SAFE_NUMBERS_DETAIL_INT128_IF_CONSTEXPR (!std::is_same<charT, char>::value)
Expand Down
Loading
Loading