fix #12944: False positive: uninitvar reported in lambda - #6975
Closed
ludviggunne wants to merge 3 commits into
Closed
fix #12944: False positive: uninitvar reported in lambda#6975ludviggunne wants to merge 3 commits into
ludviggunne wants to merge 3 commits into
Conversation
danmar
reviewed
Oct 30, 2024
| "{\n" | ||
| " int var;\n" | ||
| " auto lam = [&]() { int x = var; };\n" | ||
| " var = 5;\n" |
Collaborator
There was a problem hiding this comment.
I assume after your changes that no error will be written if var = 5; is removed?
It feels like a better fix would be in valueflow? I assume it "executes" the lambda when it is defined. It should probably skip the lambda first and then when lam() is called it can "execute" the lambda.
ludviggunne
marked this pull request as draft
November 19, 2024 08:07
Collaborator
|
Superseded by #8237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.