Open
Conversation
- Add issuer Image type property for schema conformance - Use PlugFest 3 Issuer ID - Use reworded criteria from CCG - Use demo day for issuance date - Use did:example
BigBlueHat
approved these changes
Mar 19, 2024
Contributor
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
These look fine to me. Thanks!
Contributor
|
@davidlehn any thoughts on merging this at this point? |
Contributor
I'm indifferent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open badge issuer (Profile) image property is supposed to be an object with type "Image".
Issuer ID and criteria are from w3c-ccg/vc-ed#49
Use demo day (past) as issuance date.
Use did:example rather than invalid did:key.