Introduce Github Action to build Darwin packages.#288
Open
miry wants to merge 4 commits intocrystal-lang:masterfrom
Open
Introduce Github Action to build Darwin packages.#288miry wants to merge 4 commits intocrystal-lang:masterfrom
miry wants to merge 4 commits intocrystal-lang:masterfrom
Conversation
c43b020 to
851ea63
Compare
5 tasks
Allow to run build scripts for darwin to test changes in PR.
851ea63 to
4dfb339
Compare
ysbaddaden
reviewed
Jun 10, 2024
Contributor
ysbaddaden
left a comment
There was a problem hiding this comment.
I noticed a few typos.
Versions should eventually be updated when/if this will be merged.
Comment on lines
+70
to
+73
| CRYSTAL_VERSION=1.11.0 \ | ||
| PACKAGE_ITERATION=1 \ | ||
| LLVM_VERSION=15.0.7 \ | ||
| PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=https://github.com/crystal-lang/crystal/releases/download/1.10.1/crystal-1.10.1-1-darwin-universal.tar.gz |
Contributor
There was a problem hiding this comment.
The Crystal and LLVM versions should be updated. I believe we just upgraded to LLVM 18?
Contributor
Author
There was a problem hiding this comment.
@ysbaddaden i think I asked @straight-shoota about this 1 year ago :)
If I build crystal in macos with hombrew - it used LLVM 17, but for Darwin package it was old 15.
Contributor
Author
There was a problem hiding this comment.
I need to review it again, to check if it was any changes.
Contributor
There was a problem hiding this comment.
Yeah, that's why I said if/when this is merged. Don't bother with this now :)
Co-authored-by: Julien Portalier <julien@portalier.com>
Co-authored-by: Julien Portalier <julien@portalier.com>
Co-authored-by: Julien Portalier <julien@portalier.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to run build scripts for darwin to test changes in PR.
Tests
Run a build: https://github.com/miry/distribution-scripts/actions/runs/7476572158
Download the artifact and checked arch:
PS: Feel free to modify the code or propose any changes, especially in Github action names.