Skip to content

Support for switching between official and semi-official color#1

Open
Supergamer1337 wants to merge 2 commits into
masterfrom
feature/hex-switch
Open

Support for switching between official and semi-official color#1
Supergamer1337 wants to merge 2 commits into
masterfrom
feature/hex-switch

Conversation

@Supergamer1337
Copy link
Copy Markdown

Here with a MASSIVE update for hexit.

I was bored while waiting for something to run, and so I took the massive time investment of doing something I've been thinking about many times, adding support for the semi-official secondary color, #00BABE to hexit.

I know this is a large change, and may not be merged due to this. BUT, I do think it's a very cool change. Also makes some QOL changes to the user experience.

@Chincode123
Copy link
Copy Markdown

Thanks for your contribution! It is clear that this was both a true FEAT of effort and took an IMMENSE amount of time.

Your pull-request sparks this very important question: wouldn't putting an unofficial color on an official site make that color official? This outcome would be simply unacceptable. The point of hex.chalmers.it is to show the official COLOR (singular) of the IT division.

However, adding a notifier for when the hex code is copied is an EXCELLENT example of feedback, which is especially important in an application with such a COMPLEX, INTRICATE, and UNIQUE design as hex.chalmers.it. Good job!

It is difficult for me to alone determine whether this this should be merged or not. I've given my reasoning but someone else should definitely take a look as well.

LNGTM

@Supergamer1337
Copy link
Copy Markdown
Author

While I do partly agree with this sentiment, the color has been used in various services already by the student division, and is somewhat regularly mentioned. I should feel that, by keeping #09CDDA as the standard opening color, it is shown that is the true primary, with the secondary colors being available to those that either can't use the real official color (which is often hard to use for digital screens), or want to have an alternative. Those are just my thoughts, but I don't feel strongly about the subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants