misc: write command durations to a csv file #32938
Open
+792
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/server/lib/automation/commands/record_performance_entry.ts
Outdated
Show resolved
Hide resolved
packages/server/lib/automation/commands/record_performance_entry.ts
Outdated
Show resolved
Hide resolved
jennifer-shehane
requested changes
Nov 12, 2025
cli/CHANGELOG.md
Outdated
|
|
||
| - The keyboard shortcuts modal now displays the keyboard shortcut for saving Studio changes - `⌘` + `s` for Mac or `Ctrl` + `s` for Windows/Linux. Addressed [#32862](https://github.com/cypress-io/cypress/issues/32862). Addressed in [#32864](https://github.com/cypress-io/cypress/pull/32864). | ||
| - The Cursor logo now correctly displays in the External editor dropdown. Addresses [#32062](https://github.com/cypress-io/cypress/issues/32062). Addressed in [#32911](https://github.com/cypress-io/cypress/pull/32911). | ||
| - Command execution can be benchmarked by setting the `CYPRESS_INTERNAL_COMMAND_PERFORMANCE_LOGGING` environment variable to `1` or `true`. The performance log is recorded to `./cypress/logs/performance.log` by default. Addressed in [#32938](https://github.com/cypress-io/cypress/pull/32938) |
Member
There was a problem hiding this comment.
@cacieprins If this is meant to be a user facing feature - I would not prefix this with CYPRESS_INTERNAL as that is used for truly internal env vars that users should never set.
Contributor
Author
There was a problem hiding this comment.
I think if it's something we want user-facing, it should be a config entry - but that's out of scope for this, I think. This is to prep for benchmarking visibility approaches
Member
There was a problem hiding this comment.
My comment was purely about the name of the env var having CYPRESS_INTERNAL at the beginning - as we only use this for internal env vars, like CYPRESS_INTERNAL_ENV. I would name is CYPRESS_COMMAND_PERFORMANCE_LOGGING.
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
csv-benchmark
|
| Run status |
|
| Run duration | 19m 41s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1098
|
Skipped
|
4
|
Passing
|
26989
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.18%
|
|
|---|---|
|
Untested elements
|
194
|
|
Tested elements
|
164
|
Accessibility
97.93%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
3 moderate
2 minor
|
|
Failed elements
|
102
|
packages/server/lib/automation/commands/record_performance_entry.ts
Outdated
Show resolved
Hide resolved
packages/server/lib/automation/commands/record_performance_entry.ts
Outdated
Show resolved
Hide resolved
… log writer more resiliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
If
CYPRESS_INTERNAL_COMMAND_PERFORMANCE_LOGGINGis enabled, Cypress will:./cypress/logs/performance-${UUID}.log. The random UUID is generated when the run begins.startTime- when the Command Queue began executing the commandduration- How long the command took to executename- The name of the commandSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Adds env-gated logging of each command’s execution timing to a CSV file and wires it through driver → automation (CDP/BiDi) → server.
CYPRESS_INTERNAL_COMMAND_PERFORMANCE_LOGGING):runCommandasync, measurestartTime/duration, capturenumElements, and emitCypress.automation('log:command:performance', ...)fromcommand_queue.ts.record_performance_entryto append CSV rows to./cypress/logs/performance.log(path override viaCYPRESS_INTERNAL_PERFORMANCE_LOG_FILE_PATH) and initialize file on mode start (modes/index.ts).log:command:performancethrough generic automation, plus CDP (cdp_automation.ts) and BiDi (bidi_automation.ts) handlers.CommandPerformanceEntryand new automation command in@packages/types.Written by Cursor Bugbot for commit d80bf84. This will update automatically on new commits. Configure here.