Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 16, 2025

Additional details

In looking at how this package was being used, it seemed to be missing the path setup. The ffprobe path is now set when video_capture.ts loads, ensuring it's configured for all video operations, not just in tests.

  • Upgrades @ffprobe-installer/ffprobe from 1.1.0 to 2.1.2 to support darwin-arm64 (Apple Silicon).
  • Moved ffprobe path setup so it's configured at module load time
  • Removed redundant ffprobe setup from system-tests/test/video_compression_spec.js

Note

Configures ffprobe globally for video operations, upgrades @ffprobe-installer/ffprobe to 2.1.2, removes redundant test setup, and updates changelog.

  • Server (video capture):
    • Set ffprobe path at module load in packages/server/lib/video_capture.ts via ffmpeg.setFfprobePath(ffprobePath).
    • Upgrade @ffprobe-installer/ffprobe to 2.1.2 and move to runtime dependencies in packages/server/package.json.
  • Tests:
    • Remove redundant ffprobe path configuration from system-tests/test/video_compression_spec.js.
  • Docs/Changelog:
    • Add cli/CHANGELOG.md entry for 15.8.2 describing the fix and dependency update.

Written by Cursor Bugbot for commit 2ef7181. This will update automatically on new commits. Configure here.

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane changed the title Ffprobe path update fix: Ffprobe path update Dec 16, 2025
@jennifer-shehane jennifer-shehane self-assigned this Dec 16, 2025
@cypress
Copy link

cypress bot commented Dec 16, 2025

cypress    Run #68149

Run Properties:  status check passed Passed #68149  •  git commit 2ef71810b3: Merge branch 'develop' into ffprobe-path-update
Project cypress
Branch Review ffprobe-path-update
Run status status check passed Passed #68149
Run duration 14m 00s
Commit git commit 2ef71810b3: Merge branch 'develop' into ffprobe-path-update
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  42.86%
  Untested elements 4  
  Tested elements 3  
Accessibility  96.69%
  Failed rules  1 critical   1 serious   0 moderate   0 minor
  Failed elements 3  

@jennifer-shehane jennifer-shehane changed the title fix: Ffprobe path update fix: Configure ffprobe path + bump ffprobe dep Dec 19, 2025
@jennifer-shehane jennifer-shehane merged commit 3a3b798 into develop Dec 20, 2025
94 of 95 checks passed
@jennifer-shehane jennifer-shehane deleted the ffprobe-path-update branch December 20, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants