-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: Configure ffprobe path + bump ffprobe dep #33136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ffprobe-path-update
|
| Run status |
|
| Run duration | 14m 00s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
4
|
|
|
46
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
42.86%
|
|
|---|---|
|
|
4
|
|
|
3
|
Accessibility
96.69%
|
|
|---|---|
|
|
1 critical
1 serious
0 moderate
0 minor
|
|
|
3
|
AtofStryker
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In looking at how this package was being used, it seemed to be missing the path setup. The ffprobe path is now set when video_capture.ts loads, ensuring it's configured for all video operations, not just in tests.
Note
Configures ffprobe globally for video operations, upgrades
@ffprobe-installer/ffprobeto 2.1.2, removes redundant test setup, and updates changelog.packages/server/lib/video_capture.tsviaffmpeg.setFfprobePath(ffprobePath).@ffprobe-installer/ffprobeto2.1.2and move to runtimedependenciesinpackages/server/package.json.system-tests/test/video_compression_spec.js.cli/CHANGELOG.mdentry for 15.8.2 describing the fix and dependency update.Written by Cursor Bugbot for commit 2ef7181. This will update automatically on new commits. Configure here.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?