Support WAN SciTag markers for remote HTTP(S) TPC transfers#8042
Support WAN SciTag markers for remote HTTP(S) TPC transfers#8042kofemann merged 1 commit intodCache:masterfrom
Conversation
kofemann
left a comment
There was a problem hiding this comment.
Hi @ShawnMcKee, thanks for the contribution. I have some minor comments. The code looks good. Please annotate commits with Signed -off-by: tags.
|
|
||
| @Override | ||
| public String getTransferTag() { | ||
| return transferTag == null ? "" : transferTag; |
There was a problem hiding this comment.
The extra null check is redundant, as initial value and setter alwast set "" for nulls
There was a problem hiding this comment.
Good catch. I removed the redundant null check in getTransferTag(). The value is normalized to "" by the setter and by deserialization fallback, so returning the field directly is sufficient. Included in commit 5b4768f.
| } | ||
|
|
||
| private String sanitiseHeaderValue(String value) { | ||
| if (value == null) { |
There was a problem hiding this comment.
I wish there was a comment saying that "-" is a magic placeholder to indicate nulls.
There was a problem hiding this comment.
Added an explicit sentinel constant and comment to document the magic placeholder: MISSING_HEADER_VALUE = "-" now represents missing/blank SciTag header values. I also replaced the literal "-" checks with that constant for readability. Included in commit 5b4768f.
| @@ -192,6 +197,14 @@ public static URI getTpcDestination(HttpServletRequest request) { | |||
| return (URI) request.getAttribute(TPC_DESTINATION_ATTRIBUTE); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It's good practice to have javadoc for public methods
There was a problem hiding this comment.
Agreed. I added Javadocs for the public accessor methods introduced for request attributes (getTpcSource, getTpcDestination, getTpcSciTag, and getTpcTransferHeaderSciTag). Included in commit 5b4768f.
d2f44bd to
5b4768f
Compare
|
Note on validation with all three SciTag PRs (8039, 8040, 8042): To test the full SciTag stack together, I created branch combo/8039-8040-8042. Why this was needed:
So a direct master-only test branch would miss #8040. The combo branch starts from the 11.2 side (to include #8040) and layers the corresponding #8039/#8042 changes for integrated validation. |
Signed-off-by: Shawn McKee <smckee@umich.edu>
5b4768f to
88a9be1
Compare
|
Thanks for the update.I have merges #8040 into the master too. In general, please issue PR against master. We will do the backports. |
Summary
This PR implements the agreed Patch 1-3 scope for WAN SciTag marker support.
Patch 1: Pool marker protocol allowlist
Patch 2: WebDAV TPC transfer-tag plumbing for remote HTTP(S)
Patch 3: Access-log observability
Validation Evidence
Validated on umfs19 with dcdum02 TPC traffic:
Out of Scope