DAOS-18539 cart: detect SLINGSHOT_VNIS when set#17583
Open
DAOS-18539 cart: detect SLINGSHOT_VNIS when set#17583
Conversation
Prevent server from passing fabric_auth_key to client Clean up ep_credit/ctx_max_num/crt_timeout init parsing Remove ENV_STR_NO_PRINT that was used to hide env var content Signed-off-by: Jerome Soumagne <jerome.soumagne@hpe.com>
|
Ticket title is 'CART support for DAOS commands with VNIs' |
Collaborator
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17583/1/testReport/ |
tanabarr
requested changes
Feb 20, 2026
Contributor
tanabarr
left a comment
tanabarr
left a comment
There was a problem hiding this comment.
requesting changes just so the question can be answered
| // WithFabricAuthKey sets the top-level fabric authorization key. | ||
| func (cfg *Server) WithFabricAuthKey(key string) *Server { | ||
| cfg.Fabric.AuthKey = key | ||
| cfg.ClientEnvVars = common.MergeKeyValues(cfg.ClientEnvVars, []string{cfg.Fabric.GetAuthKeyEnv()}) |
Contributor
There was a problem hiding this comment.
If we aren't using cfg.Fabric.GetAuthKeyEnv here and it's not used elsewhere do we need to remove it and anything related from the fabric structure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent server from passing fabric_auth_key to client
Clean up ep_credit/ctx_max_num/crt_timeout init parsing
Remove ENV_STR_NO_PRINT that was used to hide env var content
Steps for the author:
After all prior steps are complete: